Changes between Version 18 and Version 19 of SubmittingPatches


Ignore:
Timestamp:
Jan 4, 2017, 1:47:18 AM (4 months ago)
Author:
rutsky
Comment:

add info about make flake8, make pylint + rename "slave" to "worker"

Legend:

Unmodified
Added
Removed
Modified
  • SubmittingPatches

    v18 v19  
    77 * Individual patches should, to the extent possible, be single-purpose.  Please do not lump all of the changes you made to get Buildbot working the way you like into a single patch!
    88 * Patches must reliably pass all tests.  Buildbot does not tolerate "flaky" tests.  If you have trouble with tests that fail without any of your changes applied, get in touch with the developers for help.
    9  * Patches should pass `pyflakes` - most often pyflakes failures are unused imports, which are easy to clean up.
    10  * Patches should pass `pylint --rcfile common/pylintrc buildbot buildslave`.  Pylint takes a while longer to run, and is much more thorough than pyflakes.
     9 * Patches should pass `flake8 --config=common/flake8rc` - most often pyflakes failures are unused imports, which are easy to clean up. Try `make flake8` in sources root directory.
     10 * Patches should pass `pylint --rcfile common/pylintrc buildbot worker`.  Pylint takes a while longer to run, and is much more thorough than flake8. Try `make pylint` in sources root directory.
    1111 * Python code in Buildbot uses four-space indentations, with no tabs.  Lines should be wrapped before the 80th column.
    1212 * Patches that add features or change existing behavior should include a brief description in `master/docs/relnotes/index.rst`.  You can reference bug numbers with {{{:bug:`1234`}}} and pull reqests with {{{:pull:`233`}}}.