![[Buildbot Logo]](/chrome/site/header-text-transparent.png)
Ticket #986 (closed defect: fixed)
VC9 does not give the correct path to devenv.exe
| Reported by: | JDelfour | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.8.2 |
| Version: | 0.8.1 | Keywords: | windows |
| Cc: |
Description
In buildbot.steps.vstudio.py, VC9 installdir defaults to 'C:\Program Files\Microsoft Visual Studio 8'" whereas it's installdir is 'C:\Program Files\Microsoft Visual Studio 9'.
this can be easily bypassed by forcing a path when creating the step, but it's a bug.
Also the VC9 class (alias) is missing from the package 0.8.1.
Change History
comment:1 Changed 3 years ago by dustin
- Keywords windows added; Visual Studio removed
- Milestone changed from 0.8.+ to 0.8.2
comment:2 Changed 3 years ago by JDelfour
I don't have the git clone setup but if i look at the file, the default install path is "C:Program Files (x86)Microsoft Visual Studio 9.0" and not "C:Program FilesMicrosoft? Visual Studio 9" (at least it is for VS2008 Professional)
There is also an enhancement (i guess):
I usually prefer doing a "clean" before a "build" without using the "rebuild" (which sometimes mess the dependencies...
I guess you should add the following in the command lines : if self.mode == "clean":
command.append("/Clean")
Thanks
comment:3 Changed 3 years ago by dustin
Can you open a new bug for the enhancement? Without the ability to test, I need to do these commits in very small increments.
I've updated the branch at the URL above with the correct installdir. Is the " (x86)" in the first path component important?
comment:4 Changed 3 years ago by JDelfour
Done: http://buildbot.net/trac/ticket/987
I guess the x86 if visual studio has been installed on a 64 bits computer. We see more and more 64 bits OS nowadays :) At the end, this value can be overwritten by setting the parameter...
Thanks!
Well, as for the missing alias - yes, that was added after 0.8.1 was released. You'll notice it's also missing from all previous versions of Buildbot :)
As for the wrong installdir: I have a patch here:
but I can't test it. If you can test this patch out and let me know that it works, I'll get it committed in 0.8.2. If anyone from the windows team can help, that would be great, too!