Opened 8 years ago

Last modified 3 years ago

#984 new enhancement

remove revlink support from status hierarchy, putting it in changesources instead

Reported by: moschny Owned by:
Priority: major Milestone: 0.9.+
Version: Keywords: web, sprint
Cc: thomas.moschny@…

Description

The revlink option of WebStatus can be a callable which gets a revision id and a repository specifier. Would be nice if it also got the project parameter.

Change History (16)

comment:1 Changed 8 years ago by dustin

  • Milestone changed from undecided to 0.8.2

comment:2 Changed 8 years ago by marcusl

It shouldn't be that hard to fix. Problem is, can we make a backwards compatible fix somehow, or is it ok to break 0.8.x code?

(I don't think many are using this feature yet, but I might be wrong...)

comment:3 Changed 8 years ago by dustin

I think several people are using it. But it's a small enough change that I'd be happy with a loud note in NEWS and expecting users to fix it in their configs.

comment:4 Changed 8 years ago by moschny

  • Cc thomas.moschny@… added

One could also check the arity of the revlink method and call it with the right number of parameters. This would retain backwards compatibility.

comment:5 Changed 8 years ago by dustin

That's tricky, since func_code.co_argcount includes "self" in a method, even if the method is bound.

Let's stick with simpler-is-better and just make a small backward-compatibility break.

comment:6 Changed 8 years ago by dustin

  • Keywords web added

comment:7 Changed 8 years ago by dustin

  • Milestone changed from 0.8.2 to 0.8.3

Also, be very careful to get the quoting right here!

comment:8 Changed 8 years ago by dustin

  • Milestone changed from 0.8.3 to 0.8.+

comment:9 in reply to: ↑ description Changed 7 years ago by tom.prince

Would it perhaps make sense to just pass a dictionary (or perhaps kwargs) instead. The only issue would be that sometimes revlink is called for a source stamp, and sometimes for a change.

comment:10 Changed 7 years ago by dustin

  • Keywords sprint added

comment:11 Changed 6 years ago by dustin

  • Milestone changed from 0.8.+ to 0.9.0

This will change for nine anyway.

comment:12 Changed 5 years ago by tardyp

I would expect this revlink functionality should be put in changesource instead of status. changes already have a revlink in the db and data

Maybe I miss something, but I would suggest this API to be dropped in favor of clean api in changesources

comment:13 Changed 4 years ago by dustin

Agree with Pierre, and I think 0.9.0 is a good time to make this change.

comment:14 Changed 4 years ago by dustin

  • Summary changed from per-project revlink to remove revlink support from status hierarchy, putting it in changesources instead

comment:15 Changed 4 years ago by dustin

  • Version 0.8.1 deleted

comment:16 Changed 3 years ago by dustin

  • Milestone changed from 0.9.0 to 0.9.+
Note: See TracTickets for help on using tickets.