Incorrect build results in the database

[PiotrSikora]

Only 'success' and 'failed' results are recorded in the database, everything else (including 'exception' !) is saved as 'success'.

For example, build #86, which resulted in exception (visible in WebStatus?), has recorded result 0 ('success') in the database:

sqlite> SELECT complete, results FROM buildsets JOIN builds ON (buildsets.id=builds.brid) WHERE builds.number=86;
1|0

Looking at all results in the database, it seems that everything is either 0 'success' or 2 'failed'. There are no other results:

sqlite> SELECT DISTINCT complete, results FROM buildsets;
0|
1|0
1|2

[Dustin J. Mitchell]

Mark a buildset FAILED if anything was worse than WARNINGS

In particular, if a build's result was EXCEPTION, this will cause the whole buildset to be represented as FAILED in the database. This has implications for downstream schedulers, but not for the web status.

Fixes #969

Changeset: ea9c2a8f5a63eeba1ad4c4c421d3281f4dbdce6c

[dustin]

To be clear, the web status still displays the right stuff, because it's not pulling data from the database. But the buildset for a failed (exception) build should indicate failure. Which is to say, I think it's intentional that the results column has only two states, but certainly "exception" should be mapped to "failed", not "success".