Ticket #963 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

DirectoryLister has no getAuthz

Reported by: bcmpinc Owned by:
Priority: major Milestone: 0.8.2
Version: 0.8.1 Keywords:
Cc:

Description

The DirectoryLister? in web/base.py is missing the getAuthz method. This method is required by ContextMixin?'s getContext. The result is that directory listing does not work.

How to reproduce

  • Create a directory in the public_html directory of your buildbot.
  • Navigate to that directory using a browser.
  • This gives an exception page.

Solution The getAuthz method is defined in HtmlResource?, which is a subclass of ContextMixin?. Moving the method to ContextMixin? solves the problem. It is probably a good idea to also move the getBuildmaster method.

Change History

comment:1 Changed 3 years ago by bcmpinc

This bug was introduced by the fix of #688

comment:2 Changed 3 years ago by Dustin J. Mitchell

  • Status changed from new to closed
  • Resolution set to fixed

move getAuthz and getBuildmaster to ContextMixin?

ContextMixin? depends on getAuthz, after all. Fixes #963

Changeset: eedde195779b9249c6c882d1a6b0b0b8730e8a08

comment:3 Changed 3 years ago by tfogal

Did this hit 0.8.1? I'm getting the same error after upgrading. It cherry-picks cleanly to the buildbot-0.8.1 branch.

Since 0.8.2 isn't out yet, and we can't downgrade due to the security issue, could this get cherry-picked to 0.8.1?

comment:4 Changed 3 years ago by Dustin J. Mitchell

move getAuthz and getBuildmaster to ContextMixin?

ContextMixin? depends on getAuthz, after all. Fixes #963

Changeset: ade281e8d0746a7a9822e9f453c3020248676cc9

Note: See TracTickets for help on using tickets.