Ticket #96 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

IrcStatusBot gets exceptions.AttributeError when reporting on builder that is waiting on a slave lock

Reported by: clepple Owned by:
Priority: minor Milestone: 0.7.7
Version: 0.7.5 Keywords: IRC
Cc:

Description

I have two builders on one host, and they share a slave lock to serialize builds (to reduce thrashing).

When one of the builders is blocked by the other builder, I get the following message from "buildbot: status" in IRC:

<buildbot> Something bad happened (see logs): exceptions.AttributeError

And the following message shows up in twistd.log:

2007/09/05 16:40 EDT [IrcStatusBot,client] irc command status
2007/09/05 16:40 EDT [IrcStatusBot,client] Traceback (most recent call last):
          File "/sw/lib/python2.4/site-packages/twisted/protocols/basic.py", line 232, in dataReceived
            why = self.lineReceived(line)
          File "/sw/lib/python2.4/site-packages/twisted/words/protocols/irc.py", line 1480, in lineReceived
            self.handleCommand(command, prefix, params)
          File "/sw/lib/python2.4/site-packages/twisted/words/protocols/irc.py", line 1492, in handleCommand
            method(prefix, params)
          File "/sw/lib/python2.4/site-packages/twisted/words/protocols/irc.py", line 1037, in irc_PRIVMSG
            self.privmsg(user, channel, message)
        --- <exception caught here> ---
          File "/sw/lib/python2.4/site-packages/buildbot/status/words.py", line 138, in privmsg
            meth(user, reply, args.strip())
          File "/sw/lib/python2.4/site-packages/buildbot/status/words.py", line 242, in command_STATUS
            self.emit_status(reply, b.name)
          File "/sw/lib/python2.4/site-packages/buildbot/status/words.py", line 388, in emit_status
            s = "(%s)" % " ".join(step.getText())
        exceptions.AttributeError: 'NoneType' object has no attribute 'getText'

Change History

comment:1 Changed 6 years ago by warner

  • Milestone changed from undecided to 0.7.7

comment:2 Changed 6 years ago by warner

  • Status changed from new to closed
  • Resolution set to fixed

I've pushed a change that ought to fix this (by using the string '(no current step)' instead of exploding), in [9b49f791b4259c4a6281d82ddbac2ddbcca12915].

Note: See TracTickets for help on using tickets.