Visual Studio steps not working in v 0.8.1

[cowo]

Buildbot v0.8.1 / activepython 2.6 / windows 7 for both master and slave, visual studio 2008.

If I create a step like

s2 = VC8(
  mode = "rebuild",
  projectfile = "msvc/solution.sln",
  config = "Release",
  installdir = "msvc_base_installation",
  useenv = False,
  arch = "x86"
)

When the step is then evaluated on the slave it yields:

devenv None /Rebuild None
 in dir C:DevelBuildslavelibCopan-C++uild (timeout 1200 secs)
 watching logfiles {}
 argv: ['devenv', 'None', '/Rebuild', 'None']
 environment:

Properties like "projectfile" somehow are lost. Turns out that the VisualStudio steps don't issue a call to self.addFactoryArguments()
I'm attaching a patch against 0.8.1 code that SEEMS to solve the problem (tested a couple of times). Also adds support for VCExpress 2008.

[dustin]

I pushed this here:

 http://github.com/djmitche/buildbot/commit/bug929

Ben, can you take a look and let me know if this looks ok? If so, I'll push it (or you can).

[Ben]

I looked at it and modified it a bit, but just saw you made the same corrections as I did. The only thing I did more (beside empty lines modifications) is that I aliased VC8 as VC9 and then VS2008 as VC9

Attaching my one for completeness.

[Ben]

My unifying + refactoring of the patch

[Benoît Allard]

Fix handling of VisualStudio? steps args, add VCExpress 2008

Original patch by Giuseppe Corbelli <cowo78@…>; fixes #929.

Changeset: bd6b3c22ecaf692b368c252b616a6f7e85e96acb