Opened 8 years ago

Last modified 4 years ago

#921 assigned enhancement

buildmaster logging should be more segregated

Reported by: bhearsum Owned by: tom.prince
Priority: major Milestone: 0.9.+
Version: 0.8.0 Keywords: sprint
Cc: dwlocks

Description

In situations where many builders are running at the same time the master side log gets very confusing when trying to trace the execution of a single build. I think it would be much more sensible to segregate different types of logs on the master. It should be configurable, of course, but for a default I'd SWAG:

  • Each builder (possibly) build gets its own log file
  • Everything else goes in twistd.log (or whatever the name ends up being).

I think it would be nice to allow ChangeSources? and BuildSlave events to have their own log files too, but I don't think they are busy enough in the general case to make that the default behaviour.

Change History (6)

comment:1 Changed 7 years ago by dustin

This is pretty hard to do, and would make correlating events even harder, since you only get second-level granularity in the logfiles.

I think a better fix is to adjust the kind of logging that builds do. Right now, there's a lot of redundant information about which methods are being called, and very little useful information. That could probably be condensed down to one line (starting step 'foo' of 'buildername' build #NNN), which would make things a bit easier to follow.

comment:2 Changed 6 years ago by dustin

  • Keywords sprint added

This is a good sprint project, even if it doesn't get "solved", any improvement to this logging will be helpful.

comment:3 Changed 6 years ago by tom.prince

from twisted.python.log import ILogContext, callWithContext

might be relevant here.

comment:4 Changed 6 years ago by tom.prince

  • Owner set to tom.prince
  • Status changed from new to assigned

Also, having structured log data.

comment:5 Changed 5 years ago by dustin

  • Cc dwlocks added

Dan - related to what we were talking about today (verbose logging)

comment:6 Changed 4 years ago by dustin

  • Milestone changed from 0.8.+ to 0.9.+

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.