revlink callback and builders view does not work together.

[cdadhemar]

Hello,

I have a get_revlink callback for my WebStatus 's revlink attribute. The callaback takes 'id' and 'repository' as first arguments as stated in the documentation.

When I access a change through /changes/124 (for instance), every thing is ok. But when I access /builders/my_builder then there are no repository linked to the revision in the 'Revision' columns. I have to make sure a repository is always defined in my callback to avoid such errors and unfortunatly cannot access revision links but in the change view.

Note: my_builder is triggered by a nightly scheduler. For builders triggered by "hg hooks" poller then I have a "Got revision" field that works, and a "Revision" field which does not work.

I am not sure I am clear enough, do not hesitate to ask for more information !

Thank you very much for your help !

Cheers, Charles-Henri

[dustin]

Can you give a bit more detail about this? Some of the code, for example, or a recipe to reproduce?

[marcusl]

IIUC, the repository property is not set on a sourcestamp when created by a scheduled build (as opposed to a triggered one), causing problems with the supplied revlink function.

The SourceStep? should be updated to add that info to the sourcestamp, if possible.

[dustin]

This is actually documented:

 585 Note that SourceStamps that are not created from version-control changes (e.g.,
 586 those created by a Nightly or Periodic scheduler) will have an empty repository
 587 string, as the respository is not known.

I'm hesitant to feed more data back into the sourcestamp from a build - I don't like the way got_revision works now.

Is it difficult to handle the empty revision string, defaulting to whatever repository you build normally?

[tom.prince]

This is an issue if you have different builders building from different repositories by default, as there is no way to tell what builder the source stamp is from.

[tom.prince]

Related: #913 #1821