Nightly scheduler fails to trigger if too many pending changes

[GillesGagniard]

buildbot issues the following sqlite query to remove pending changes when triggering a Nightly scheduler in buildbot/db/connector.py :

def scheduler_retire_changes(self, schedulerid, changeids, t):
  t.execute(self.quoteq("DELETE FROM scheduler_changes"
                        " WHERE schedulerid=? AND changeid IN ")
  + self.parmlist(len(changeids)),
  (schedulerid,) + tuple(changeids))

However, sqlite only allows for 999 variables in a sql query, so this fails if there are more than 999 pending changes.

[dustin]

So putting that in a loop wiht some (probably smaller) limit on the number of variables used in a single query would be OK?

[Dustin J. Mitchell]

retire changes in batches

SQLite, at least, has a limit on the number of parameters it can accept. Fixes #912.

Changeset: 13544de519394969839e1efc927cfa1c0866dd6d