[PATCH] Support setting of LineEnd perforce client specification property

[thomasthorsen]

Currently this is hardcoded to "local" in the P4 class (slave/commands/vcs.py):

client_spec += "LineEnd?: local

"

Out of necessity to change this to "share" to preserve UNIX line endings on our test systems, I made this change to the python files so that it is properly parameterized, so you can set it to whatever is required when using the P4 class. The change is of course backward compatible so the behaviour is unchanged if this (optional) extra parameter is not specified.

The change involves only a few extra lines in the two files: slave/commands/vcs.py steps/source.py

I've attached the two modified files.

[thomasthorsen]

buildbot/steps/source.py

[thomasthorsen]

buildbot/slave/commands/vcs.py

[dustin]

Patches are a lot easier for me to look at. If you're going to post full files, please tell me exactly what version they're written against. I think I can figure this out, though.

[dustin]

buildbot-0.8.0-based.patch

[Dustin J. Mitchell]

add line-endings option to p4 command (no docs) - refs #909

Changeset: 58f091e06de3aaac954f81e4df12ccefc07b49ae

[Dustin J. Mitchell]

documentation for p4line_end parameter - fixes #909

Changeset: 707c5f66b45e3009312fb372860b226845e1d4fb