Ticket #908 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

web status doesn't allow to force build on a revision with space char in it

Reported by: GillesGagniard Owned by:
Priority: major Milestone: 0.8.2
Version: 0.8.0 Keywords:
Cc:

Description

The force build form on a builder page enables the user to specify a revision; it is checked in buildbot/status/web/builder.py : 

if not re.match(r'^[w.-/]*$', revision):
  log.msg("bad revision '%s'" % revision)
  return Redirect(path_to_builder(req, self.builder_status))

which specifically doesn't allow blank spaces. However, a CVS revision is of form "YYYY-MM-DD HH:MM:SS", thus it is not possible to force build on a specific CVS revision.

Change History

comment:1 Changed 3 years ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from undecided to 0.8.2

fixed in

commit 8ab9855b5c346ee1df462e7a395e0681b661675b Author: Dustin J. Mitchell <dustin@…> Date: Thu Jul 1 11:43:27 2010 -0500

allow spaces in revision when forcing a build

Note: See TracTickets for help on using tickets.