Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#907 closed defect (fixed)

zip_safe is true for buildslave, and windows fails to find it

Reported by: dustin Owned by: dustin
Priority: critical Milestone: 0.8.1
Version: 0.8.0 Keywords: windows
Cc:

Description

From an email thread:

http://thread.gmane.org/gmane.comp.python.buildbot.devel/6199/focus=6209


I tested this out and found that while buildslave is installed in the Scripts directory, it still doesn't work for me. I tried running the buildslave script directly:

D:uildbot-slave-0.8.1-rc2>python c:Python26Scriptsuildslave
Traceback (most recent call last):
 File "c:Python26Scriptsuildslave", line 4, in <module>
   import pkg_resources
 File "c:Python26libsite-packagessetuptools-0.6c9-py2.6.eggpkg_resources.p
y", line 2562, in <module>
 File "c:Python26libsite-packagessetuptools-0.6c9-py2.6.eggpkg_resources.p
y", line 626, in require
 File "c:Python26libsite-packagessetuptools-0.6c9-py2.6.eggpkg_resources.p
y", line 524, in resolve
pkg_resources.DistributionNotFound: buildbot-slave==0.8.1-rc2

I compared this to running buildbot 0.8.0's script directly, which worked fine.

The corresponding bat file is also still missing. This is easy enough to fix and I can submit a patch for that, but I don't understand why easy_install thinks buildbot-slave is not installed. I did notice that it now installs an egg file instead of the extracted egg in a directory under site-packages.

Dan


I saw the patch:

http://github.com/djs/buildbot/commits/bugfix_win32

and I'll leave it to Ben to merge it, since it's a patch to the branch.

As for not finding the distribution - the buildslave package does not use file, so it can be installed as an egg (a zip file), rather than as a directory containing .py files. I wonder if this results in the setuptools being unable to find it?

Can you try rebuilding the egg from setup.py, but adding { 'zip_safe' : False } to setup_args?

Dustin


'zip_safe' : False seems to do it. I'm able to run buildslave.bat now.

Dan

Change History (3)

comment:1 Changed 10 years ago by Dustin J. Mitchell

Set zip_safe = False on Windows - refs #907

Changeset: 727661d7bbc465cb1e30fef5fdd55569a4e8d2a3

comment:2 Changed 10 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed

I also pushed

http://github.com/djs/buildbot/commit/ab9bdbba2b46d69efe004a0ff3fa897dc8e1ff95

I think this is closed for now - let's see how it performs in 0.8.1-rc3?

comment:3 Changed 10 years ago by Dustin J. Mitchell

Set zip_safe = False on Windows - refs #907

Changeset: 727661d7bbc465cb1e30fef5fdd55569a4e8d2a3

Note: See TracTickets for help on using tickets.