Ticket #90 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Make bonsaipoller ignore funkyness in xml output for empy log messages

Reported by: Pike Owned by: warner
Priority: major Milestone: 0.7.6
Version: 0.7.5 Keywords:
Cc:

Description

Bonsai's XML output doesn't collect check-ins with not check in message, and gives individual check-ins for those. That's a bug to be fixed in bonsai itself, but as not everybody is running tip bonsai, we should make bonsaipoller wallpaper around it, too.

This is upstreaming  mozilla bug 393640, r=bhearsum. The patch there includes a test, too.

Do we need a separate attachment here or is the bugzilla one good enough?

Change History

comment:1 Changed 5 years ago by warner

  • Owner set to warner
  • Status changed from new to assigned
  • Milestone changed from undecided to 0.7.6

I grabbed the attachment from bugzilla.. I'll try to apply it tonight.

comment:2 Changed 5 years ago by warner

  • Status changed from assigned to closed
  • Resolution set to fixed

I've applied this in [1a53e3909d8bb997a68f49305b1d7a8f1ce0f717], but it looks like the patch was against a version of test_bonsaipoller.py that I haven't seen yet (the patch context mentions "FakeChangeMaster?", which isn't our trunk version).

Do you folks just want to give me a copy of your bonsaipoller.py and test_bonsaipoller.py that I could dump in trunk verbatim?

Note: See TracTickets for help on using tickets.