Opened 9 years ago

Closed 9 years ago

#895 closed enhancement (fixed)

svn poller should use pass environment to getProcessOutput

Reported by: jonrafkind Owned by:
Priority: major Milestone: 0.8.2
Version: 0.7.12 Keywords: svn
Cc:

Description

svnpoller.py should pass os.environ to utils.getProcessOutput to ensure shell variables are passed along properly. In my setup (gentoo) the $HOME variable is set by the script that starts buildbot, --env HOME=$BASEDIR, and this information is only propagated to the rest of the python system through os.environ.

I do not know if this change has adverse effects on other systems.

  def getProcessOutput(self, args):
        import os
        # this exists so we can override it during the unit tests
        d = utils.getProcessOutput(self.svnbin, args, os.environ)
        return d

Change History (2)

comment:1 Changed 9 years ago by dustin

  • Keywords svn added
  • Milestone changed from undecided to 0.8.2
  • Type changed from undecided to enhancement

comment:2 Changed 9 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed

Fixed a while back:

commit b4c5301ebe43e492bfb1b8d2facb4b6bbd92588d
Author: Bill <bill@posthu.me>
Date:   Mon May 24 14:47:43 2010 -0400

    Pass the local environments variables along with getProcessOutput
    This is required for ssh agent authentication which uses:
      SSH2_AUTH_SOCK
      SSH2_CLIENT
      SSH_AA_SOCK
Note: See TracTickets for help on using tickets.