Ticket #893 (closed enhancement: duplicate)

Opened 3 years ago

Last modified 3 months ago

Mercurial source step needs username and passwd parms

Reported by: bgunnison Owned by:
Priority: major Milestone: 0.8.+
Version: 0.8.0 Keywords: hg
Cc:

Description

So we can get source from https URLs.

My workaround:

I have a Repo URL of the form:

MasterRepoURL = ' https://myusername:mypasswd@xxx.xxx.com/'

I can put the above in the clear in master.cfg, but that is not safe.

I then did this:

import base64 passwd = base64.b64decode('rgthyde34=-') #not the real string obviously

MasterRepoURL = ' https://myusername:%s@xxx.xxx.com/' % passwd

This is better, as editors of master.cfg will have to do a bit of work, I’ll improve this by putting the base64 invocation in another file.

Now the buildbot log files and the waterfall all have the password in the clear, so I modified buildstep.py where cmd.args is logged to not log if the dict contains “repourl”.

Change History

comment:1 Changed 3 years ago by dustin

  • Keywords hg added
  • Milestone changed from undecided to 0.8.+

comment:2 Changed 15 months ago by dustin

This should get added to the new master-side steps.

comment:3 Changed 3 months ago by dustin

  • Status changed from new to closed
  • Resolution set to duplicate

The more general bug to solve that is #1748

Note: See TracTickets for help on using tickets.