Ticket #892 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

revision=None breaks console view

Reported by: Shish Owned by:
Priority: major Milestone: 0.8.2
Version: 0.8.0 Keywords: web
Cc:

Description

while setting up a change notification hook I managed to invoke buildbot sendchange with no --revision flag, thus revision=None got sent and broke various things. Correcting the command and running again most stuff now works, but console view is still breaking with the error "int() argument must be a string or a number, not 'NoneType?'". The code triggering the error is: 

.../buildbot-0.8.0-py2.5.egg/buildbot/status/web/console.py, line 687 in isRevisionEarlier
685class IntegerRevisionComparator(RevisionComparator):
686  def isRevisionEarlier(self, first, second):
687    return int(first.revision) < int(second.revision)
688

Change History

comment:1 Changed 3 years ago by dustin

  • Milestone changed from undecided to 0.8.1

maybe None could be replaced by sys.maxint?

comment:2 Changed 3 years ago by dustin

  • Keywords web added

comment:3 Changed 3 years ago by bhearsum

  • Milestone changed from 0.8.1 to 0.8.2

comment:4 Changed 3 years ago by Dustin J. Mitchell

  • Status changed from new to closed
  • Resolution set to fixed

Be more resilient to non-integer revisions

Fixes #892

Changeset: b713e2f073accbdef91d124b95d9b454e0a9de72

Note: See TracTickets for help on using tickets.