steps which start within a few seconds of each other show as same start time on waterfall page

[joduinn]

We have configured scheduler2, scheduler3 defined to be dependent on scheduler1.

At this time, scheduler1 completes in approx 3 seconds, while scheduler2 and scheduler3 take much longer.

We noticed in last night's run that the waterfall page shows start times for scheduler2 and scheduler3 that are same as *start* time for scheduler1, which is wrong. Instead, the waterfall page should shows start times for scheduler2 and scheduler3 that are same as the *end* time for scheduler1.

The interesting thing is that the waterfall page does correctly show both the start and stop for scheduler1, so both of these timestamps are already displayed on the left hand side of the waterfall page. Just, for some reason, the start times of scheduler2 and scheduler3 are incorrect.

[warner]

It's been a while since I've looked closely at the waterfall-generating code, but the behavior you're seeing is probably by design. The timestamps on the left are describing the starting time of each box, and multiple steps (from multiple builders) can live in each box. The box has a window size (10 seconds, I think), and any events or steps which occur within that 10 second window will share a box.

(you'll probably notice that steps which finish very quickly will share a box too.. same reason).

does this seem to explain what you're seeing?

[warner]

poke.. do you still think this is incorrect behavior?

(we should probably add explicit timestamps to the build page, so you can see accurate start/stop times)