Ticket #867 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

p4 poller triggers assertion in _process_changes(self, result) and no more builds are scheduled

Reported by: phil Owned by:
Priority: major Milestone: 0.8.0
Version: 0.7.12 Keywords: p4 p4poller
Cc:

Description (last modified by dustin) (diff)

Error output: [-] P4 poll failed: [Failure instance: Traceback: exceptions.AssertionError?: Invalid file line: '... depot/testbad#1 move/add'

Description: The "p4 describe -s changelistnumber" command can contain changelist entries such as:

"... depot/testok#1 edit" "... depot/testbad#1 move/add" "... depot/testbad2#1 move/delete"

The regex for the changelist lines is incorrect if the changelist entries are ending with "move/add" or "move/delete" instead of just "edit" or "add". More specifically the '/' is missing in the regex expression.

Proposed solution (based on p4poller.py 0.7.12): change p4poller.py(37): 

    file_re = re.compile(r"^... (?P<path>[^#]+)#d+ w+$")

into 

    file_re = re.compile(r"^... (?P<path>[^#]+)#d+ [w/]+$")

Change History

comment:1 Changed 3 years ago by phil

  • Summary changed from p4 poller triggers assertion in _process_changes(self, result) and no more build are scheduled to p4 poller triggers assertion in _process_changes(self, result) and no more builds are scheduled

comment:2 Changed 3 years ago by dustin

  • Description modified (diff)

comment:3 Changed 3 years ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from undecided to 0.8.0

Kovarththanan already fixed this in 196196b08570a3373ed6c8889923917fddf09475. Well, he switched the order of / and w, but close enough!

Note: See TracTickets for help on using tickets.