Error on CVS repository update : None passed as revision

[GillesGagniard]

Upgrading from buildbot 0.7.12 to 0.8.0, a new issue appears with CVS support.

With a custom change source, I add changes to the task master this way :

for p in patches:

c = Change(who = pwho?, files = files, comments = pcommitlog?, branch = pbranch?) self.parent.addChange(c)

Changes appear on waterfall as expected (with a correct "Changed at" date), but when a scheduler starts a build, the revision passed to CVS is 'None' :

starting cvs operation /usr/bin/cvs -z3 update -dP -r HEAD -D None

in dir /data2/ngidelde/tools/build/buildbot/slave_97/apl_daily_project_full/ngi_1 (timeout 3600 secs) watching logfiles {} argv: ['/usr/bin/cvs', '-z3', 'update', '-dP', '-r', u'HEAD', '-D', 'None']

which obviously causes CVS to fail. In buildbot 0.7.12, the date used to be computed from the timestamps in changes. Did this behaviour changes in buildbot 0.8.0 ? How to tell the CVS build step which revision to use for update ?

[GillesGagniard]

The problem lies in the constructor of SourceStamp? :

if changes:

self.changes = tuple(changes) # set branch and revision to most recent change self.branch = changes[-1].branch self.revision = str(changes[-1].revision) if not self.project:

self.project = changes[-1].project

if not self.repository:

self.repository = changes[-1].repository

However, for changes coming from CVS, the revision attribute for changes is None, and thus

self.revision = str(changes[-1].revision)

is 'None', and not None. Since it is not None, the computeSourceRevision() method in the CVS buildstep is never called.

[dustin]

This should get fixed in 0.8.1.

[bhearsum]

We ended up bumping up 0.8.1, this will get pushed to 0.8.2.

[catlee]

Fixed in  http://github.com/buildbot/buildbot/commit/6e717ac1