Ticket #846 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Perforce password is not obfuscated

Reported by: phil Owned by:
Priority: minor Milestone: 0.8.1
Version: 0.7.12 Keywords:
Cc:

Description

The perforce password is displayed as plain text in the output logs.

This can easily be resolved by replacing the "self.p4passwd" argument with "Obfuscated(self.p4passwd, "XXXXXXXX")" in the invokations of command.extend() (commands.py)

Attachments

commands.py Download (116.1 KB) - added by phil 3 years ago.

Change History

Changed 3 years ago by phil

comment:1 Changed 3 years ago by phil

  • Type changed from undecided to enhancement

comment:2 Changed 3 years ago by dustin

What version of commands.py is that based on?

comment:3 Changed 3 years ago by dustin

  • Milestone changed from undecided to 0.8.1

comment:4 Changed 3 years ago by phil

That was commands.py from buildbot version 0.7.12.

comment:5 Changed 3 years ago by Dustin J. Mitchell

  • Status changed from new to closed
  • Resolution set to fixed

obfuscate P4 passwords - fixes #846

Changeset: dd366a28e9635fde68652a79fd77b0ffe4885706

comment:6 Changed 3 years ago by Dustin J. Mitchell

obfuscate P4 passwords - fixes #846

Changeset: dd366a28e9635fde68652a79fd77b0ffe4885706

comment:7 Changed 3 years ago by Dustin J. Mitchell

Merge branch 'master' into buildbot-0.8.0

  • master: Adding retrying logic for sqlite Add comments about why we're doing unicode encoding Fix running .exes under windows when we don't have an abolute path obfuscate P4 passwords - fixes #846 Fix error handling for _startCommand so that tracebacks get back to the Changeset: 68bbe5e24366e156dd3ce19a855e9bf05c645895

comment:8 Changed 3 years ago by Dustin J. Mitchell

obfuscate P4 passwords - fixes #846

Changeset: dd366a28e9635fde68652a79fd77b0ffe4885706

Note: See TracTickets for help on using tickets.