remove Change.links

[dustin]

Change.asDict does some weird stuff with files and links:

    def asDict(self):
        '''returns a dictonary with suitable info for html/mail rendering'''
        result = {}
    
        files = []
        for file in self.files:
            link = filter(lambda s: s.find(file) != -1, self.links)
            if len(link) == 1:
                url = link[0]
            else:
                url = None
            files.append(dict(url=url, name=file))

        files = sorted(files, cmp=lambda a,b: a['name'] < b['name'])

What is this all about? I don't know how to test it, because I don't know what it's supposed to do..

[marcusl]

I think each file can have a corresponding URL in self.links. The for loop matches them. It was there before I wrote that function (i.e. I just adapted the previous html-paste code to an asDict() instead.)

The sorting is just to get files in order, for easier human reading of the commited files list.

[marcusl]

self.links might not be used anymore. If so, we can just prune it and be happy. :)

I suppose some ChangeSource:s (via PB et.al.) might set these URLs, but I'd prefer that to be urlified in Webstatus, as we do with rev-ids.

[dustin]

see #46 for the background on this. Part 1 is removing Change.links. The other part is a better display of changes, perhaps with a simple list of the latest changes - #858.

[dustin]

Oo, removing code, I like doing that.

This is a schema change, though, so it will need to wait until SQLAlchemy lands.

[Dustin J. Mitchell]

Drop support for change links

These were never well-defined, and were only honestly created by CVS. They are much better implemented with a revlink function on the status API. Fixes #836.

Changeset: 139222f3d6edb052e6870789e68298ba6cd2811e