Need a means to set keepaliveTimeout on slaves

[dustin]

buildbot create-slave supports:

-k, --keepalive= Interval at which keepalives should be sent (in seconds)

[default: 600]

but the keepaliveTimeout is not configurable, and is hard-coded at 30 seconds. This is the time between when the slave sends a keepalive message and when it expects a response from the master.

Due to clock wonkiness or a busy master, or whatever, we see response times longer than 30 seconds, so we need to configure this.

[dustin]

2010/05/06 21:26 -0700 [Broker,client] sending application-level keepalives every 600 seconds
2010/05/06 21:36 -0700 [-] sending app-level keepalive
2010/05/06 21:46 -0700 [-] sending app-level keepalive
2010/05/06 21:57 -0700 [-] sending app-level keepalive
2010/05/06 21:57 -0700 [-] BotFactory.checkActivity: nothing from master for 662 secs
2010/05/06 21:57 -0700 [Broker,client] BotFactory.keepaliveLost
2010/05/06 21:57 -0700 [Broker,client] lost remote

[dustin]

This is no longer an issue: failing if you don't hear a response to a keepalive is wrong; rather, the keepalive is just to keep the connection alive and detect a dead connection via socket errors so that it can be destroyed and re-tried.