Buildbot tries to run alwaysRun steps even after slave connection is lost

[catlee]

If you have a step that is marked alwaysRun, buildbot will try and run the step even if the connection to the slave has been lost in a previous step.

Bug or feature?

I think it makes sense that a lost slave connection should terminate the build immediately.

[catlee]

The exception you hit when the alwaysRun step is attempted is:

2010-05-04 05:43:15-0700 [Broker,77187,10.250.50.68] Unhandled Error
	Traceback (most recent call last):
	  File "/tools/buildbot/lib/python2.5/site-packages/buildbot-0.7.10p1-py2.5.egg/buildbot/steps/shell.py", line 202, in start
	    self.startCommand(cmd, warnings)
	  File "/tools/buildbot/lib/python2.5/site-packages/buildbot-0.7.10p1-py2.5.egg/buildbot/process/buildstep.py", line 975, in startCommand
	    d = self.runCommand(cmd) # might raise ConnectionLost
	  File "/tools/buildbot/lib/python2.5/site-packages/buildbot-0.7.10p1-py2.5.egg/buildbot/process/buildstep.py", line 917, in runCommand
	    d = c.run(self, self.remote)
	  File "/tools/buildbot/lib/python2.5/site-packages/buildbot-0.7.10p1-py2.5.egg/buildbot/process/buildstep.py", line 84, in run
	    d = defer.maybeDeferred(self.start)
	--- <exception caught here> ---
	  File "/tools/twisted-8.0.1/lib/python2.5/site-packages/twisted/internet/defer.py", line 105, in maybeDeferred
	    result = f(*args, **kw)
	  File "/tools/buildbot/lib/python2.5/site-packages/buildbot-0.7.10p1-py2.5.egg/buildbot/process/buildstep.py", line 505, in start
	    return LoggedRemoteCommand.start(self)
	  File "/tools/buildbot/lib/python2.5/site-packages/buildbot-0.7.10p1-py2.5.egg/buildbot/process/buildstep.py", line 303, in start
	    return RemoteCommand.start(self)
	  File "/tools/buildbot/lib/python2.5/site-packages/buildbot-0.7.10p1-py2.5.egg/buildbot/process/buildstep.py", line 110, in start
	    d = self.remote.callRemote("startCommand", self, self.commandID,
	exceptions.AttributeError: 'NoneType' object has no attribute 'callRemote'

[dustin]

Sounds like a bug, but not a showstopper for 0.8.0.

[catlee]

Fixed by

[catlee]

 http://github.com/buildbot/buildbot/commit/ccbd4c88f32634e6aada8cfe818d94fd148c6753