change manager ignores changeHorizon

[dustin]

The change-pruning code is commented out. What are the consequences of pruning changes in the DB?

[dustin]

We need to answer this in 0.8.2. Catlee?

[catlee]

First naive approach (just deleting changes older than changeHorizon) causes at least the web status to blow up:

	    data = self.content(request, ctx)
	  File "/home/catlee/src/buildbot/master/buildbot/status/web/builder.py", line 66, in content
	    source = pb.getSourceStamp()
	  File "/home/catlee/src/buildbot/master/buildbot/status/builder.py", line 751, in getSourceStamp
	    br = self.db.getBuildRequestWithNumber(self.brid)
	  File "/home/catlee/src/buildbot/master/buildbot/db/connector.py", line 762, in getBuildRequestWithNumber
	    brid)
	  File "/home/catlee/src/buildbot/master/buildbot/db/connector.py", line 212, in runInteractionNow
	    return self._runInteractionNow(interaction, *args, **kwargs)
	  File "/home/catlee/src/buildbot/master/buildbot/db/connector.py", line 237, in _runInteractionNow
	    result = interaction(c, *args, **kwargs)
	  File "/home/catlee/src/buildbot/master/buildbot/db/connector.py", line 776, in _txn_getBuildRequestWithNumber
	    ss = self.getSourceStampNumberedNow(ssid, t)
	  File "/home/catlee/src/buildbot/master/buildbot/db/connector.py", line 509, in getSourceStampNumberedNow
	    ss = self._txn_getSourceStampNumbered(t, ssid)
	  File "/home/catlee/src/buildbot/master/buildbot/db/connector.py", line 551, in _txn_getSourceStampNumbered
	    ss = SourceStamp(branch, revision, patch, changes, project=project, repository=repository)
	  File "/home/catlee/src/buildbot/master/buildbot/sourcestamp.py", line 54, in __init__
	    self.branch = changes[-1].branch
	exceptions.AttributeError: 'NoneType' object has no attribute 'branch'

[dustin]

I think you'll just need to delete sourcestamp_changes too, right? Let me put a patch together and see what you think.

[dustin]

What do you think:

 http://github.com/djmitche/buildbot/commit/a77debe6227eac0581b809501aab1db603e7270b

[catlee]

I think we need to be careful that the sourcestamp isn't referenced by any active builds.

[dustin]

Why? This doesn't delete the sourcestamp, just its changes -- it becomes a change-less sourcestamp after that, which is a perfectly normal state. Did I miss something?

[dustin]

catlee -- any further thoughts on this issue?

[dustin]

commit 294a81c86198e8f105bb0eff1532193ef557ee0e
Merge: c7b3530 a77debe
Author: Dustin J. Mitchell <dustin@zmanda.com>
Date:   Mon Sep 6 21:17:39 2010 -0500

    Merge branch 'bug817'
    
    * bug817:
      implement the changeHorizon