Ticket #811 (closed defect: fixed)

Opened 22 months ago

Last modified 20 months ago

Twisted 2.5.0, test failure: buildbot.test.unit.test_util_loop

Reported by: clepple Owned by:
Priority: minor Milestone: undecided
Version: 0.8.0 Keywords:
Cc:

Description

OS: Ubuntu 8.04

Python: 2.5.2-0ubuntu1 (from .deb package)

Twisted: 2.5.0 (from .deb packages)

branch: buildbot-0.8.0 (c512b5bcb529; 2 commits past 0.8.0rc1 tag)

One test failure: 

[ERROR]: buildbot.test.unit.test_util_loop
Traceback (most recent call last):
 File "/usr/lib/python2.5/site-packages/twisted/trial/runner.py", line 555, in loadPackage
   module = modinfo.load()
 File "/usr/lib/python2.5/site-packages/twisted/python/modules.py", line 386, in load
   return self.pathEntry.pythonPath.moduleLoader(self.name)
 File "/usr/lib/python2.5/site-packages/twisted/python/modules.py", line 621, in moduleLoader
   return self._moduleLoader(modname)
 File "/usr/lib/python2.5/site-packages/twisted/python/reflect.py", line 357, in namedAny
   topLevelPackage = __import__(trialname)
 File "/home/clepple/dl/buildbot/buildbot/test/unit/test_util_loop.py", line 42, in <module>
   from twisted.python import monkey
exceptions.ImportError: cannot import name monkey

Change History

comment:1 Changed 22 months ago by Dustin J. Mitchell

  • Status changed from new to closed
  • Resolution set to fixed

do not use twisted.python.monkey, which is not in tw-2.5.0

This module wasn't actually used in test_util_loop, anyway. However, the test module does use TestCase?.patch, which doesn't exist on older Twisteds. So this commit monkeypatches that method to just skip tests that use it on older Twisteds. Fixes #811

Changeset: 380d4d947efed9e74fcf5e5911222f16a2643842

comment:2 Changed 22 months ago by Dustin J. Mitchell

do not use twisted.python.monkey, which is not in tw-2.5.0

This module wasn't actually used in test_util_loop, anyway. However, the test module does use TestCase?.patch, which doesn't exist on older Twisteds. So this commit monkeypatches that method to just skip tests that use it on older Twisteds. Fixes #811

Changeset: 380d4d947efed9e74fcf5e5911222f16a2643842

comment:3 Changed 20 months ago by Dustin J. Mitchell

do not use twisted.python.monkey, which is not in tw-2.5.0

This module wasn't actually used in test_util_loop, anyway. However, the test module does use TestCase?.patch, which doesn't exist on older Twisteds. So this commit monkeypatches that method to just skip tests that use it on older Twisteds. Fixes #811

Changeset: 380d4d947efed9e74fcf5e5911222f16a2643842

Note: See TracTickets for help on using tickets.