build properties should let scheduler overwrite change properties [PATCH]

[Pike]

Right now, build properties first ask the build request, aka, the scheduler, and then the change properties.

From a information flow, I think it'd be more logical to do it the other way around.

It also breaks the use-case I'd have for properties, which is, attaching the locale to a change, and then have the scheduler determine which locales it'd build for that change. Right now, I'd have to put the locale of the change into a different property, and ignore that one in the build.

I have a hard time figuring out a use case for the opposite, or maybe just a hard time trying :-)

Original code is by bhearsum, so putting him on CC.

[bhearsum]

I don't think that configuration-time objects should override runtime ones. Scheduler, Builder, and BuildSlave properties should always take a back seat to Change and other run-time set properties. Can the thing that is generating the Changes deal with the properties, or can that logic be in the build system itself rather than Buildbot?

I'm interested in other people's thoughts on the matter, though.

[Pike]

Pushed  http://github.com/Pike/buildbot/commit/f6fe64544577a7ec1af66882c3bd9eac358839f6, based on 0.7.12 right now, because that's what I'll need for the time being.

I expect that to merge OK.

[Axel Hecht]

first, get properties from changes, then from the scheduler. This way, the scheduler can overwrite source properties (fixes #809)

Changeset: ff20ae3230853bd3fef361441d5a08bc3aef8acd

[Axel Hecht]

first, get properties from changes, then from the scheduler. This way, the scheduler can overwrite source properties (fixes #809)

Changeset: ff20ae3230853bd3fef361441d5a08bc3aef8acd

[Axel Hecht]

first, get properties from changes, then from the scheduler. This way, the scheduler can overwrite source properties (fixes #809)

Changeset: b2d9931816121105e542177d43df14de16c88c50