Opened 10 years ago

Closed 9 years ago

#808 closed enhancement (fixed)

Blame info lost across trigger step->scheduler

Reported by: parente Owned by:
Priority: minor Milestone: 0.8.3
Version: 0.7.12 Keywords: buildcoord
Cc:

Description

Example:

1) SVNPoller scheduler S1 runs builder B1. (B1 has blame info from SVN) 2) Builder B2 triggers scheduler S2. 3) Scheduler S2 runs builder B2. (B2 does not have blame info)

Fix that appears to work:

In sourcestamp.py, SourceStampClass?, method getAbsoluteSourceStamp add:

if got_revision == self.revision: return self

as the first line.

Change History (5)

comment:1 Changed 10 years ago by dustin

  • Milestone changed from undecided to 0.8.+
  • Type changed from undecided to enhancement

I'm worried that will break other things. We need some more flexible handling of sourcestamp transformations.

comment:2 Changed 9 years ago by dustin

  • Keywords buildcoord added
  • Milestone changed from 0.8.+ to 0.8.1

comment:3 Changed 9 years ago by dustin

  • Milestone changed from 0.8.2 to 0.8.3

comment:4 Changed 9 years ago by parente

I've been running with this fix locally for 5 months now without an issue. Granted, I'm not touching every part of buildbot, but it's a start.

comment:5 Changed 9 years ago by Dustin J. Mitchell

  • Resolution set to fixed
  • Status changed from new to closed

Make absolute SourceStamps? also copy .changes from the original

Fixes #808.

Changeset: 8f4dc94001d006f59b5d1cc467b1a473af83372c

Note: See TracTickets for help on using tickets.