Disable patch output in twistd.log

[maruel]

This ticket is about changing the functionality of buildbot.process.buildstep.LoggingBuildStep?.startCommand() to not log the actual patch even if present. It will simply logs its length instead. Only relevant to buildbot try/try server.

I'm not a fan of making it optional, it just adds yet another untested code path.

See  http://codereview.chromium.org/1759006 as an implementation.

Another possible implementation would be to change the patch argument to be an object, make it act like a tuple and change its repr. I think it's overkill.

[dustin]

Clarification from IRC conversation: This means not logging the patch in the stdio logfile - the patch is still available via the web interface.

[Dustin J. Mitchell]

Reduce verbosity in twistd.log on the try server.

Remove the patch from the 'patch' argument when logging.

from  http://src.chromium.org/viewvc/chrome?view=rev&revision=45608 fixes #803

Changeset: 470da7404d2ce994e535f587e08a336e4633d016

[Dustin J. Mitchell]

Revert "Reduce verbosity in twistd.log on the try server."

This reverts commit 470da7404d2ce994e535f587e08a336e4633d016. refs #803

Changeset: 72f24712992376b82068942831fa9e5e4e8bc8d5

[dustin]

Reverted.

We should still do this, but as written the patch caused problems when checking out source without a patch. Also, I'm not sure why it's in the LoggingBuildStep class and not in the Source class.

[Dustin J. Mitchell]

Reduce verbosity in twistd.log on the try server.

Remove the patch from the 'patch' argument when logging.

from  http://src.chromium.org/viewvc/chrome?view=rev&revision=45608 fixes #803

Changeset: 470da7404d2ce994e535f587e08a336e4633d016