Opened 8 years ago

Last modified 8 years ago

#801 new defect

getLastFinishedBuild() fails with simultaneous builds

Reported by: maruel Owned by: maruel
Priority: critical Milestone: 0.9.+
Version: master Keywords:
Cc:

Description

If you connect 2 slaves on a builder and call IBuilderStatus.getLastFinishedBuild() on the builder, it will fail to return the last completed build if both are building simultaneously.

This function should be changed to do a loop instead but a trivial loop won't work since IBuilderStatus.getBuild() may return None when it has pending requests, it should still be clamped when it hits the end of the build list in case there is no finished build yet.

This currently breaks console view with simultaneous builds.

I want to write a unit test first. :)

Change History (3)

comment:1 Changed 8 years ago by dustin

  • Milestone changed from undecided to 0.8.1

comment:2 Changed 8 years ago by dustin

  • Milestone changed from 0.8.2 to 0.8.3

comment:3 Changed 8 years ago by ayust

  • Milestone changed from 0.8.3 to 0.9.+
Note: See TracTickets for help on using tickets.