Ticket #792 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

[PATCH] rmdirRecursive follows symlinks

Reported by: dustin Owned by:
Priority: major Milestone: 0.8.2
Version: 0.7.12 Keywords:
Cc:

Description

If you have a symlink to a file you don't own, rmdirRecursive (buildbot/slave/commands/utils.py) will try to chmod it, and fails. I think we should be using lchmod, but that's only in Python 2.6.. Maybe we should just be using shutil.rmtree on POSIX?

Attachments

patch.diff Download (461 bytes) - added by ccomb 3 years ago.
a patch to avoid recursing in symlinks

Change History

Changed 3 years ago by ccomb

a patch to avoid recursing in symlinks

comment:1 Changed 3 years ago by dustin

  • Summary changed from rmdirRecursive follows symlinks to [PATCH] rmdirRecursive follows symlinks

comment:2 Changed 3 years ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed

We're using shutil.rmtree on POSIX now.

Note: See TracTickets for help on using tickets.