Ticket #763 (closed defect: fixed)

Opened 23 months ago

Last modified 18 months ago

debug client calls now-missing perspective_requestBuild

Reported by: dustin Owned by:
Priority: major Milestone: 0.8.2
Version: 0.7.12 Keywords:
Cc: boris.savelev@…

Description

This method was taken out of DebugPerspective, but DebugClient still uses it. I don't have the equipment (GTK+) to run the debug client, so I can't fix this myself.

Attachments

buildbot_0.8.1_add_perspective_requestBuild.diff Download (796 bytes) - added by bsavelev 18 months ago.
add perspective_requestBuild to DebugPerspective? in master.py

Change History

comment:1 Changed 22 months ago by dustin

  • Milestone changed from 0.8.0 to 0.8.1

Moving to next release, unless someone can step up and do this

comment:2 Changed 21 months ago by dustin

  • Status changed from new to closed
  • Resolution set to duplicate

closed in favor of the larger #848

comment:3 Changed 21 months ago by dustin

  • Status changed from closed to reopened
  • Resolution duplicate deleted

oops - that's statusgui, this is debug client.

comment:4 Changed 19 months ago by bsavelev

  • Cc boris.savelev@… added

comment:5 Changed 18 months ago by bsavelev

can I ask here, why method perspective_requestBuild was removed?

comment:6 Changed 18 months ago by dustin

the BuilderControl.requestBuild method no longer exists. I don't recall why I removed the debugclient method instead of changing it, but here was the commit:

commit 0c2de79bcbc782631a3a5a821fd4871875000c29
Author: Dustin J. Mitchell <dustin@zmanda.com>
Date:   Mon Feb 15 21:22:50 2010 -0600

    requestBuild no longer exists; uses submitBuildRequest
    
    This removes the reference from the DebugPerspective, and fixes the
    rebuild button on the web status

If you can supply a patch that you can verify works, I'll be happy to merge it!

Changed 18 months ago by bsavelev

add perspective_requestBuild to DebugPerspective? in master.py

comment:7 Changed 18 months ago by bsavelev

attachment:ticket:763:buildbot_0.8.1_add_perspective_requestBuild.diff Download with this change I can force builder throw debugclient

comment:8 Changed 18 months ago by Dustin J. Mitchell

  • Status changed from reopened to closed
  • Resolution set to fixed

Re-add perspective_requestBuild to DebugClientPerspective?

fixes #763

Changeset: dc0636a0d534bdbeb315bc06ffbb5c2e79ca7d65

Note: See TracTickets for help on using tickets.