Ticket #763 (closed defect: fixed)
debug client calls now-missing perspective_requestBuild
| Reported by: | dustin | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 0.8.2 |
| Version: | 0.7.12 | Keywords: | |
| Cc: | boris.savelev@… |
Description
This method was taken out of DebugPerspective, but DebugClient still uses it. I don't have the equipment (GTK+) to run the debug client, so I can't fix this myself.
Attachments
Change History
comment:2 Changed 3 years ago by dustin
- Status changed from new to closed
- Resolution set to duplicate
closed in favor of the larger #848
comment:3 Changed 3 years ago by dustin
- Status changed from closed to reopened
- Resolution duplicate deleted
oops - that's statusgui, this is debug client.
comment:5 Changed 3 years ago by bsavelev
can I ask here, why method perspective_requestBuild was removed?
comment:6 Changed 3 years ago by dustin
the BuilderControl.requestBuild method no longer exists. I don't recall why I removed the debugclient method instead of changing it, but here was the commit:
commit 0c2de79bcbc782631a3a5a821fd4871875000c29
Author: Dustin J. Mitchell <dustin@zmanda.com>
Date: Mon Feb 15 21:22:50 2010 -0600
requestBuild no longer exists; uses submitBuildRequest
This removes the reference from the DebugPerspective, and fixes the
rebuild button on the web status
If you can supply a patch that you can verify works, I'll be happy to merge it!
Changed 3 years ago by bsavelev
-
attachment
buildbot_0.8.1_add_perspective_requestBuild.diff
added
add perspective_requestBuild to DebugPerspective? in master.py
comment:7 Changed 3 years ago by bsavelev
attachment:ticket:763:buildbot_0.8.1_add_perspective_requestBuild.diff with this change I can force builder throw debugclient
comment:8 Changed 3 years ago by Dustin J. Mitchell
- Status changed from reopened to closed
- Resolution set to fixed
Re-add perspective_requestBuild to DebugClientPerspective?
fixes #763
Changeset: dc0636a0d534bdbeb315bc06ffbb5c2e79ca7d65
![[Buildbot Logo]](/chrome/site/header-text-transparent.png)
Moving to next release, unless someone can step up and do this