buildbot.db.exceptions.DatabaseNotReadyError on buildbot start (make error more helpful)

[chrb]

From 0.8.0 d6d8554819b5877f61b6b68007134f8e8e8ddcac

2010-03-26 15:51:01+0000 [-] Log opened.
2010-03-26 15:51:01+0000 [-] twistd 8.2.0 (/usr/bin/python 2.6.4) starting up.
2010-03-26 15:51:01+0000 [-] reactor class: twisted.internet.selectreactor.SelectReactor.
2010-03-26 15:51:01+0000 [-] Creating BuildMaster -- buildbot.version: latest
2010-03-26 15:51:01+0000 [-] loading configuration from /home/chrb/buildmaster/master.cfg
2010-03-26 15:51:01+0000 [-] unable to import dnotify, so Maildir will use polling instead
2010-03-26 15:51:01+0000 [-] BuildMaster listening on port tcp:9989
2010-03-26 15:51:01+0000 [-] configuration update started
2010-03-26 15:51:01+0000 [-] Unhandled Error
        Traceback (most recent call last):
          File "/usr/lib/python2.6/dist-packages/buildbot/master.py", line 480, in loadTheConfigFile
            d = self.loadConfig(f)
          File "/usr/lib/python2.6/dist-packages/buildbot/master.py", line 782, in loadConfig
            d.addCallback(lambda res:
          File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 195, in addCallback
            callbackKeywords=kw)
          File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 186, in addCallbacks
            self._runCallbacks()
        --- <exception caught here> ---
          File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 328, in _runCallbacks
            self.result = callback(self.result, *args, **kw)
          File "/usr/lib/python2.6/dist-packages/buildbot/master.py", line 783, in <lambda>
            self.loadConfig_Database(db_url, db_poll_interval))
          File "/usr/lib/python2.6/dist-packages/buildbot/master.py", line 892, in loadConfig_Database
            self.loadDatabase(db_spec, db_poll_interval)
          File "/usr/lib/python2.6/dist-packages/buildbot/master.py", line 856, in loadDatabase
            raise exceptions.DatabaseNotReadyError
        buildbot.db.exceptions.DatabaseNotReadyError: 

[dustin]

Did the preceding "create-master" invocation work?

[chrb]

I'll mark this as invalid since I did not know to run "buildbot upgrade-master", which I have now done and the error no longer occurs. The error message itself is a bit unintuitive.

[dustin]

The error message could be improved!

[Dustin J. Mitchell]

Improve the DatabaseNotReady? error message. Fixes #761.

Changeset: ee904f47b8fe3212ef0d2f80b0b4369f1676e5f3

[dustin]

          File "/home/dustin/code/buildbot/t/buildbot/buildbot/master.py", line 873, in loadDatabase
            to make a backup of your buildmaster before doing so.""")
        buildbot.db.exceptions.DatabaseNotReadyError: 
        The Buildmaster database needs to be upgraded before this version of buildbot
        can run.  Use the following command-line
            buildbot upgrade-master path/to/master
        to upgrade the database, and try starting the buildmaster again.  You may want
        to make a backup of your buildmaster before doing so.

[Dustin J. Mitchell]

Improve the DatabaseNotReady? error message. Fixes #761.

Changeset: ee904f47b8fe3212ef0d2f80b0b4369f1676e5f3