![[Buildbot Logo]](/chrome/site/header-text-transparent.png)
Ticket #74 (closed enhancement: fixed)
Detect warnings in Compile and Test steps (revised)
| Reported by: | rochg | Owned by: | warner |
|---|---|---|---|
| Priority: | major | Milestone: | 0.8.3 |
| Version: | 0.7.5 | Keywords: | |
| Cc: | umesh.patel@… |
Description
This patch allows for warnings to be detected in Compile and Test steps. Warnings are gathered in a warnings summary file which can be viewed on the Waterfall.
A new class (WarningCountingShellCommand?) is added, which makes it easy for shell commands other than Compile and Test to use this functionality.
The class provides a default pattern to spot warnings in the shell command output, but the user can override this when adding a step in their config file e.g.:
factory.addStep(Compile,
command=make -C build?, warnOnWarnings="True", warningPattern="(.*warning-found.*)|(.*warning[: ].*)")
Also included is a change to the e-mail sending logic so that mails are sent out when builds have warnings.
This is a revised patch following feedback that should replace SourceForge? patches 1751945 and 1685048.
Attachments
-
shell.py.diff
(2.9 KB) -
added by rochg 6 years ago.
-
mail.py.diff
(3.0 KB) -
added by rochg 6 years ago.
-
081p1_mail.py
(22.2 KB) -
added by umesh4 3 years ago.
-
bug74.patch
(11.2 KB) -
added by dustin 3 years ago.
- patch version
Change History
comment:3 Changed 5 years ago by warner
- Status changed from new to assigned
I updated this a bit and wrote some tests. I need to review the setup a bit (and write docs) but it looks likely to make it into 0.7.7.
comment:4 Changed 5 years ago by warner
- Status changed from assigned to closed
- Resolution set to fixed
committed, in [bbb4668b4cedda210e08074da0b7113b49509813]. Thanks!
comment:5 Changed 4 years ago by umesh4
- Status changed from closed to reopened
- Resolution fixed deleted
Doesn't look like the e-mail sending logic part of this (mail.py) has been incorporated. Any chance you could?
comment:6 Changed 4 years ago by dustin
The patch doesn't apply anymore .. can you redraft it against the latest?
comment:8 Changed 3 years ago by dustin
- Status changed from reopened to closed
- Resolution set to fixed
This is mostly merged..
comment:9 Changed 3 years ago by umesh4
- Status changed from closed to reopened
- Resolution fixed deleted
Looks like the email sending logic isn't incorporated in 0.8.1p1, so I've drafted a new copy of mail.py against 0.8.1p1, attached as 081p1_mail.py. Incorporated a new mode, 'warnings', which sends out a mail if the build completes with a status of SUCCESS or WARNINGS.
comment:11 Changed 3 years ago by dustin
Oops, ignore that.
comment:12 Changed 3 years ago by Umesh Patel
- Status changed from reopened to closed
- Resolution set to fixed
New MailNotifier? mode, 'warning'
Incorporated a new mode, 'warnings', which sends out a mail if the build completes with a status of SUCCESS or WARNINGS. Fixes #74
Changeset: 6afe6500c80ca2f9eb8d35356cc84e14d554185c
comment:13 Changed 3 years ago by dustin
- Milestone changed from 0.8.+ to 0.8.3
The fix didn't make it to 0.8.2, but it will be in the next release.