Ticket #730 (closed defect: fixed)

Opened 2 years ago

Last modified 20 months ago

Pending builds not displayed

Reported by: catlee Owned by: dustin
Priority: blocker Milestone: 0.8.0
Version: master Keywords:
Cc:

Description

In version 95d054247cdab08bac88e7fb8df2f01242a2a7b3, the list of pending builds in the per-builder view isn't populated with data, nor are counts of pending builds listed on the waterfall.

I suspect BuilderStatus?.pendingBuilds is now useless, as it should be getting its information from the database.

In addition, I believe that the requestSubmitted / requestCancelled status notifications are no longer getting called. BuilderStatus?.addBuildRequest/removeBuildRequest aren't called anywhere now.

Change History

comment:1 Changed 2 years ago by dustin

  • Priority changed from major to blocker

#733 was a dupe

comment:2 Changed 23 months ago by catlee

  • Owner set to warner
  • Status changed from new to assigned

comment:3 Changed 22 months ago by dustin

Also blocking beta2..

comment:4 Changed 22 months ago by dustin

  • Owner changed from warner to dustin

comment:5 Changed 22 months ago by Dustin J. Mitchell

  • Status changed from assigned to closed
  • Resolution set to fixed

Merge branch 'misc-fixes' of  git://github.com/warner/buildbot

  • 'misc-fixes' of  git://github.com/warner/buildbot: fix web handling of getPendingBuilds() and cancel() implement IBuildRequestControl.cancel(), add unit tests for cancel() fixes for IBuilderStatus: getPendingBuilds, subscribe/unsubscribe handles for requestSubmitted and requestCancelled, and IStatus's buildSetSubmitted notification

Fixes #730 Signed-off-by: Dustin J. Mitchell <dustin@…>

Changeset: 198f2ed83fc83ad13166973e6329c41d733b9f2e

comment:6 Changed 20 months ago by Dustin J. Mitchell

Merge branch 'misc-fixes' of  git://github.com/warner/buildbot

  • 'misc-fixes' of  git://github.com/warner/buildbot: fix web handling of getPendingBuilds() and cancel() implement IBuildRequestControl.cancel(), add unit tests for cancel() fixes for IBuilderStatus: getPendingBuilds, subscribe/unsubscribe handles for requestSubmitted and requestCancelled, and IStatus's buildSetSubmitted notification

Fixes #730 Signed-off-by: Dustin J. Mitchell <dustin@…>

Changeset: 198f2ed83fc83ad13166973e6329c41d733b9f2e

Note: See TracTickets for help on using tickets.