Ticket #725 (closed enhancement: fixed)

Opened 2 years ago

Last modified 20 months ago

start testing with a clean slate

Reported by: dustin Owned by: dustin
Priority: blocker Milestone: 0.8.0
Version: master Keywords:
Cc:

Description

Our tests are in terrible shape, and that inertia is preventing people from writing new tests.

I'm going to move _all_ of the tests to buildbot.broken_test and not run them in the buildbots anymore. I'll slowly move tests back to buildbot.test, rewriting them to be well-encapsulated, readable, well-isolated _unit_ tests.

Change History

comment:1 Changed 2 years ago by Dustin J. Mitchell

move all tests to buildbot.broken_test (refs #725)

This moves everything (well, almost - I moved test_authz back just so the buildbots will have something to test) out of the way.

Changeset: 429ed202252d60f401c825e307845af041f8fc9a

comment:2 Changed 2 years ago by Dustin J. Mitchell

test_util_ComparableMixin (refs #725)

Changeset: 51c4752dc895fa496373e10cc2d0a9f4b24655d5

comment:3 Changed 2 years ago by Dustin J. Mitchell

add tests for buildbot.db.DB (refs #725)

Changeset: d5d23880386a0943ef422c4fab7fb19edf343e59

comment:4 Changed 2 years ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed

This ticket instructs me to _start_ testing with a clean slate. I've started. This is hard to finish because most of the components of buildbot are badly isolated and thus difficult to test reliably in isolation.

So this will remain an ongoing struggle.

comment:5 Changed 2 years ago by Dustin J. Mitchell

(refs #725) update NEWS regarding newly-passing buildbot tests

Changeset: d5bdaaa857676013ad2ddb35678ceb9a2728cbec

comment:6 Changed 20 months ago by Dustin J. Mitchell

move all tests to buildbot.broken_test (refs #725)

This moves everything (well, almost - I moved test_authz back just so the buildbots will have something to test) out of the way.

Changeset: 429ed202252d60f401c825e307845af041f8fc9a

Note: See TracTickets for help on using tickets.