Ticket #724 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

buildbot.test.runs.test_db.Base uses 'shutDown' instead of 'tearDown'

Reported by: dustin Owned by:
Priority: critical Milestone: 0.8.0
Version: master Keywords:
Cc:

Description

as a result, this method is never called, which is at least one source of bad test isolation.

Unfortunately, renaming it to tearDown leads to other errors, even after changing db.close to db.stop. This is over my head.

Change History

comment:1 Changed 3 years ago by Dustin J. Mitchell

disable badly-isolated buildbot.test.runs.test_db.{Create,MigrateChanges?,Generic} (refs #724)

Changeset: c6e69ccf464e688848a9024e7f88f6a09d0d82ba

comment:2 Changed 3 years ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed

..and the tests are completely removed in #725

comment:3 Changed 3 years ago by Dustin J. Mitchell

disable badly-isolated buildbot.test.runs.test_db.{Create,MigrateChanges?,Generic} (refs #724)

Changeset: c6e69ccf464e688848a9024e7f88f6a09d0d82ba

Note: See TracTickets for help on using tickets.