Ticket #686 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Git step retry doesn't work?

Reported by: dustin Owned by:
Priority: major Milestone: 0.7.12
Version: 0.7.11 Keywords:
Cc:

Description

On Fri, Jan 15, 2010 at 6:46 AM, Guo Hongruan wrote:

I found that the retry parameter of source.Git in buildbot.steps does

not work at all. If the buildbot failed to checkout source code from Git, it can not retry the next time. Instead of retry to checkout source code, the buildbot throw out an exception and causes the builder failed.

Can you file a bug? I didn't realize there *was* retry behavior - what is the purpose of this? To support checkouts over flaky connections?

It looks like the immediate bug could be fixed (only os.mkdir(..) if not os.path.exists(..)), but it really should be tested, and there might be larger problems beyond this one.

Change History

comment:1 Changed 3 years ago by Dustin J. Mitchell

  • Status changed from new to closed
  • Resolution set to fixed

(fixes #686) always do a clobber when retrying a VC operation

Changeset: c99f51d39e61d6aa1b0cb8a9abfc6bf5edfa2f62

Note: See TracTickets for help on using tickets.