CVS export options ignored by slave

[satyagraha]

According to the CVS manual, the export operation should support the -N option (to preserve the full directory tree and not elide intermediate directories), see  http://www.cs.utah.edu/dept/old/texinfo/cvs/cvs_18.html#SEC86 . Having this facility available is important in my application.

In the slave/command.py doVCFull() the checkout_options are ignored unless the operation is 'checkout'. So, I propose this test is removed as being unnecessarily restrictive: a patch via git will be pushed in due course.

[satyagraha]

Patch now at:  http://github.com/satyagraha/buildbot/commit/b9866f1f224c531dc43a32d0ac1bdd8b8049e578

[dustin]

commit b9866f1f224c531dc43a32d0ac1bdd8b8049e578
Author: Satyagraha 1956 <satyagraha.1956@googlemail.com>
Date:   Sat Jan 9 20:26:47 2010 +0000

    Fix for #676 .

[warner]

This patch causes test_vc to fail on my OS-X 10.6 box (CVS version 1.12.13), because it causes a "-P" (prune empty directories) option to be passed to "cvs export", which does not accept it.

satyagraha: did this unit test pass for you before you submitted this patch?

I suppose that any given installation is likely to stick to either mode=export or mode=checkout, and so it doesn't much matter that there are some checkout_options that are acceptable to one command but not the other. On the other hand, the option name ("checkout_options) makes less sense if it's being used for both "checkout" and "export". We could either rename it to just plain "cvs_options", or create a new "export_options" that only gets used for export.

At the very least, the unit tests need to pass, and there needs to be a note in the buildbot docs explaining what checkout_options are for (and that they are used for both checkout and export).

[Dustin J. Mitchell]

Add extra_options and export_options to CVS

This allows you to flexibly add extra options for both 'checkout' and 'export', or both. Fixes #676.

Changeset: 3b09726708c51e60825f36f88f6ebde98d220a07

[Dustin J. Mitchell]

Add extra_options and export_options to CVS

This allows you to flexibly add extra options for both 'checkout' and 'export', or both. Fixes #676.

Changeset: 3b09726708c51e60825f36f88f6ebde98d220a07