Ticket #668 (closed undecided: fixed)

Opened 3 years ago

Last modified 3 years ago

Allow unsetting env variables on ShellCommand

Reported by: abyx Owned by:
Priority: major Milestone: 0.8.+
Version: 0.7.11 Keywords: shell shellcommand env environ
Cc: abyx

Description

The buildbot's default environ might contain some values that are not wanted in the testing environment. Simply setting it to "" (empty string) will not always work, if the step can't even have the value there. And, setting it to None will not work as python's environ will complain.

There should be an option such that providing an environ to ShellCommand? with None values will del those from the environ.

Change History

comment:1 Changed 3 years ago by dustin

  • Milestone changed from undecided to 0.8.+

I'm planning to address this thoroughly in remsh, but yes, it would be good to have a way to "edit" the slave env, instead of just setting variables

comment:2 Changed 3 years ago by Benoit Allard

  • Status changed from new to closed
  • Resolution set to fixed

Allow ShellCommand? to unset environment variables (fix #668)

Changeset: b68b85dfbdf53c18e1ea19bd2f3f9d7f16861397

comment:3 Changed 3 years ago by Benoit Allard

Allow ShellCommand? to unset environment variables (fix #668)

Changeset: 9fd7df87c02c3d7674536ba3edf407ad622df156

comment:4 Changed 3 years ago by Benoit Allard

Allow ShellCommand? to unset environment variables (fix #668)

Changeset: 9fd7df87c02c3d7674536ba3edf407ad622df156

comment:5 Changed 3 years ago by Benoit Allard

Allow ShellCommand? to unset environment variables (fix #668)

Changeset: b68b85dfbdf53c18e1ea19bd2f3f9d7f16861397

Note: See TracTickets for help on using tickets.