Ticket #643 (closed defect: fixed)
Problems with /grid and /tgrid
|Reported by:||knielsen||Owned by:||knielsen|
I have problems with /grid and /tgrid in latest Buildbot git.
The problem is that there are lots of rows for each revision (where there should be only one), and most of the cells are empty.
The problem appears to be with the comparison between SourceStamp? objects for the different builds. The grid/tgrid pages in the same row those builds which have identical SourceStamp?. But one component of SourceStamp? is changes.changes.Change, and this class seems to be a new instance for each build. Since class Change use the default equality based on reference, this makes most builds appear in different rows, even if the actual content of the underlying Change objects are the same.
Not sure if all sources show this behaviour. I see this using Bzr, specifically BzrLaunchpadEmailMaildirSource?.
I plan to fix by adding a ComparableMixin? into changes.changes.Change.