Ticket #630 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

MailNotifier fails with default settings

Reported by: heiko.bihr Owned by:
Priority: major Milestone: 0.8.+
Version: 0.7.11 Keywords:
Cc:

Description

Using the default message in MailNotifier? and perforce as VCS, the composition of the mail message fails when appending the revision number (see attached trace).

The appended patch fixes this by not adding the revision number using the += operator, but string formatting instead.

Attachments

traceback.txt Download (1.6 KB) - added by heiko.bihr 4 years ago.
Traceback
fix.patch Download (455 bytes) - added by heiko.bihr 4 years ago.
fix (unified diff against buildbot-0.7.11p3)

Change History

Changed 4 years ago by heiko.bihr

Traceback

Changed 4 years ago by heiko.bihr

fix (unified diff against buildbot-0.7.11p3)

comment:1 Changed 4 years ago by lowekamp

  • Summary changed from MailNotifier fails with perforce to MailNotifier fails with default settings

Also occurs with svn (or anything else with revision numbers, I guess)

comment:2 Changed 4 years ago by ipv6guru

  • Milestone changed from undecided to 0.7.+

Yes, confirmed this happens in our svn setup too.

comment:3 Changed 4 years ago by dustin

Thanks! Committed

comment:4 Changed 3 years ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.