p4poller ignores environment variables

[hooaarzt]

I'am trying to set up my buildmaster (on CentOS 5.3; RHEL 5 compatible) to monitor a perforce source tree. Basically, the example from section 5.6 of the buildbot 0.7.11 manual works with my testing perforce server.

Unfortunately my production perforce server uses unicode, so the perforce command line client needs the environment variable P4CHARSET to be set. So I start the buildmaster from within its base dir as follows:

# export P4CHARSET=utf8

# twistd --no_save -y buildbot.tac

When the buildmaster execs the p4 binary, the spawned process does not have P4CHARSET in its environment any more causing the p4 binary to fail. Even other environment variables like DISPLAY are ripped off of the environment. Trying to specify the perforce server and user through the environment variables P4PORT and P4USER does not work either.

I assume, that p4poller runs the p4 binary in a somewhat limited environment.

[hooaarzt]

master.cfg file of the buildmaster

[dustin]

Hmm, this needs some TLC from someone knowledgeable about Perforce.. presumably we need a new config option or two.

[Kovarththanan Rajaratnam]

P4Poller: pass through important environment variables (fixes #625)

Previously all variables had to be passed through as command line arguments (through P4Source). Note, environment variables do not have higher precedence than command line arguments, so this shouldn't break any existing users.

Changeset: bc44cbe9fed2cc732098fc12cebc6790d7c43097