bonsaipoller bug fixes

[Pike]

bonsaipoller has a few bugs, which we fixed on the mozilla side, see  bug 389645.

There's going to be a follow-up patch to use twistd.web instead of liburl to query bonsai without blocking and with a timeout.

[Pike]

support empty check-in comments, fix files array for multiple check-ins

[Pike]

I just landed  bug 389706, which replaces the call to urllib.urlopen with twisted.web.client.getPage. That's making bonsai poller query bonsai asynchronously, and adds support for timeouts, too. Thus, a dying bonsai doesn't block the complete master anymore. It's reviewed by bhearsum.

[Pike]

use twisted.web.client.getPage instead of urllib.urlopen

[warner]

I tried applying these to current HEAD, but test_bonsaipoller then failed. Am I doing something wrong?

[warner]

Here are the test failures I observed:

===============================================================================
[ERROR]: buildbot.test.test_bonsaipoller.TestBonsaiPoller.testFullyFormedResult

Traceback (most recent call last):
  File "/home/warner/stuff/Projects/BuildBot/trees/bonsaipoller/buildbot/test/test_bonsaipoller.py", line 119, in testFullyFormedResult
    br = BonsaiParser(StringIO(goodUnparsedResult))
  File "/home/warner/stuff/Projects/BuildBot/trees/bonsaipoller/buildbot/changes/bonsaipoller.py", line 78, in __init__
    raise InvalidResultError("Malformed XML in result")
buildbot.changes.bonsaipoller.InvalidResultError: 'Malformed XML in result'
===============================================================================
[ERROR]: buildbot.test.test_bonsaipoller.TestBonsaiPoller.testMissingCiResult

Traceback (most recent call last):
  File "/home/warner/stuff/Projects/BuildBot/trees/bonsaipoller/buildbot/test/test_bonsaipoller.py", line 171, in testMissingCiResult
    BonsaiParser(StringIO(missingCiResult))
  File "/home/warner/stuff/Projects/BuildBot/trees/bonsaipoller/buildbot/changes/bonsaipoller.py", line 78, in __init__
    raise InvalidResultError("Malformed XML in result")
buildbot.changes.bonsaipoller.InvalidResultError: 'Malformed XML in result'
-------------------------------------------------------------------------------

[Pike]

use content instead of StringIO for tests, now that BonsaiParser? takes content

[Pike]

oops, you caught me not running tests, obviously. Sorry.

The fix is simple, as the bonsai content handlers now take content instead of file-like objects, we mustn't use StringIO.

[Pike]

Just landed the fix for the tests on our repository, with r=bhearsum.

[warner]

applied, in [c1cb11a5d0377e42766c8d79b32edb2545ec62e9].