RSS & Atom failure with "Request did not return a string"

[ddunbar]

When attempting to access the RSS and atom feeds, twistd fails with: -- Request did not return a string

Request:

<GET /atom HTTP/1.1>

Resource: <buildbot.status.web.feeds.Atom10StatusResource instance at 0x101ac8b48>

Value: --

I think the problem is that Atom10StatusResource.item is returning a unicode string. I'm not sure of the correct fix, but returning str(data) instead seems to solve the problem.

[dustin]

cherry-picked in [4dcda7197e346f8dba56978f670cddca34cca340]

[cdadhemar]

Rss failure error report

[cdadhemar]

Hello,

I reopen the bug : I have still this issue using Buildbot 0.7.12 (I verified that the patch mentioned above was correctly applied).

Note that in the failure report of my step their are some c++/valgrind and home made test suites output that might produce some characters not filtered by twisted's html.escape method.

However for reporting the errors in the html/waterfall view I use : from xml.sax.saxutils import escape Which works great.

I hope it helped ! Cheers, Chicha

[marcusl]

FWIW, for 0.8 we use jinja to generate rss feeds, so this error should be fix there.

For 0.7.x series, we should encode it to utf-8 and this should be stated in the heading of the xml document.

[dustin]

marcusl: even better -- we're just not doing 0.7.x anymore :)

Marking as fixed, since it's fixed in the new code.

[cdadhemar]

Hi dustin,

Do you mean that this is fixed in 0.8 (the dev branch) and that the next release will be the 0.8 branch (no more 0.7.x releases) ?

This sounds like a great news :-) Thanks !

[dustin]

cdadhemar: yes to both.

I'm still reserving the option to do another 0.7.* release if 0.8.0 doesn't pan out as well as I'd like, but with luck we'll jump straight to 0.8.0 and be done with it.

[cdadhemar]

Thanks a lot !