triggered build failure doesn't stop triggering builder

[TTimo]

if a triggered builder fails, the triggering builder doesn't stop despite a haltOnFailure

[dustin]

I can't replicate this - I just set up the following config:

from buildbot.scheduler import Scheduler, Periodic, Triggerable
c['schedulers'] = []
c['schedulers'].append(Scheduler(name="all", branch=None,
                                 treeStableTimer=0,
                                 builderNames=["builder"]))
c['schedulers'].append(Triggerable(name="sub", builderNames=['subbuilder']))

from buildbot.process import factoryfrom buildbot.steps.source import SVN, P4
from buildbot.steps.shell import ShellCommand, PerlModuleTestfrom buildbot.steps.transfer import FileDownload
from buildbot.steps.trigger import Triggerfrom buildbot.steps.python_twisted import Trial
from buildbot.process.properties import WithProperties
f0 = factory.BuildFactory()
f0.addStep(Trigger(schedulerNames=['sub'], waitForFinish=True, haltOnFailure=True))
f0.addStep(ShellCommand(command="true"));

f1 = factory.BuildFactory()
f1.addStep(SVN(baseURL='http://what/ever/', defaultBranch='trunk'))
f1.addStep(ShellCommand(command="sleep 5", logEnviron=False))
f1.addStep(ShellCommand(command="cat main.cp"))
f1.addStep(ShellCommand(command="false", flunkOnFailure=True))

from buildbot.config import BuilderConfig
c['builders'] = [ { 
            'name': "builder",
            'slavename': "bot",
            'builddir': "builder",
            'factory': f0, 
          },  
          BuilderConfig(
            name = "subbuilder",
            slavenames = "bot",
            factory = f1, 
          ) ] 

and it seems to work fine. Are you sure the triggered build is actually failing (flunkOnfailure=True)?