custom properties for triggerable schedulers

[dustin]

Discussion was here:

 http://article.gmane.org/gmane.comp.python.buildbot.devel/2064

This basically provides an alternative to the dependent scheduler, allowing more sophisticated scheduling of inter-dependent builders.

[dustin]

buildsteps can trigger schedulers

[dustin]

Note that the tests in this patch require the patch from #57.

[dustin]

Also note that, if #71 is applied, this patch should be modified to use it.

[gward]

This patch is still useful and relevant with Buildbot 0.7.6. It applies cleanly, and *almost* works. In particular, it works fine as long as you keep using the 0.7.5 style of

factory.addStep(Trigger, ...)

but if you switch to the 0.7.6 style

factory.addStep(Trigger(...))

it fails. This is because BuildStep.init() is not saving enough kwargs in self.factory, which in turn is because Trigger.init() does not pass all of its kwargs up. I'll attach one possible fix (as a patch relative to Dustin's original patch).

[gward]

0.7.6 compatibility fix (allows passing Trigger instances to factory.addStep())

[dustin]

Updated patch against latest head. This, too,has been requested a few times on the mailing list, so I'd like to see it in the next release. Available as 'triggerable.patch' in  http://darcs.r.igoro.us/buildbot/trunk.

[spiff]

Is this patch missing a patch to sourcestamp.py? I don't see where getAbsoluteSourceStamp is defined.

[dustin]

spiff -- that's in #71.

[redsymbol]

Custom props to triggers for 0.7.6. Assumes customprops076.tgz and customprops_web.diff from ticket #87 have been applied, as well as trigger.patch and bb-item56-0.7.6fix.patch from this ticket

[dustin]

everything but the customprops patch is available as "#56:trigger.patch" from  http://darcs.r.igoro.us/buildbot/dustin/.

[warner]

I've applied all the 56-related patches from dustin's repository, and done some further cleanups on top of them (renamed schedulers= to schedulerNames=, and make updateSourceStamp be True by default). I'll look at the "custom props" patches now.

[warner]

Ok, I don't understand the "custom properties" stuff, like what is the difference between a custom property and a regular one. I'm going to rename the remainder of this ticket to "custom properties for triggerable schedulers" and push it out to the next release. At least the base triggerable stuff is now in 0.7.7 .

[dustin]

This got solved in #87/#124.