Ticket #53 (closed defect: fixed)
Twisted 2.5 no longer needs win32 platform detection
|Reported by:||long.in.the.tooth||Owned by:||warner|
Installing buildbot from CVS, using Python 2.4 and Twisted 2.5 (for Python 2.4)
buildbot start .
Received this error: T
raceback (most recent call last): File "c:Python24Scriptsuildbot", line 4, in ? runner.run() File "C:Python24Libsite-packagesuildbotscripts unner.py", line 725, in run start(so) File "C:Python24Libsite-packagesuildbotscriptsstartup.py", line 73, in start return launch(config) File "C:Python24Libsite-packagesuildbotscriptsstartup.py", line 110, in launch from twisted.scripts._twistw import run ImportError: cannot import name run
Seems twisted 2.5 now does the platform detection itself, so we can simplify startup.py by taking out the platformType check on line 108.
Just import the 'run' function directly, as per the diff below:
Index: buildbot/scripts/startup.py =================================================================== RCS file: /cvsroot/buildbot/buildbot/buildbot/scripts/startup.py,v retrieving revision 1.4 diff -r1.4 startup.py 109,112c109 < if platformType == "win32": < from twisted.scripts._twistw import run < else: < from twisted.scripts.twistd import run --- > from twisted.scripts.twistd import run
- Priority changed from minor to critical
- Status changed from new to assigned
- Status changed from assigned to closed
- Resolution set to fixed
- Status changed from closed to reopened
- Resolution fixed deleted