Opened 10 years ago

Last modified 9 years ago

#520 new enhancement

add per-build comments from Waterfall page

Reported by: ipv6guru Owned by:
Priority: major Milestone: 2.0.+
Version: 0.7.10 Keywords: web
Cc: daniel@…

Description (last modified by dustin)

Ben Hearsum would like to see a Tinderbox feature ported to buildbot: a link on each build that offers viewers a way to add comments to the build, some sort of text box.

I think the cleanest way to implement this would be with a Build Property named "comments", and to extend IBuildStatus to include a setProperty() method. Now, all the I*Status interfaces are supposed to be read-only, but I'm thinking it would be easier to relax this requirement than to add a parallel set of I*StatusWriter? interfaces (not unlike the existing IBuildControl interface) just for this one purpose.

In addition to that, we'd need changes to html.StepBox? to add the link, a new class (and URL target) to display/edit the comments, and maybe a new parameter to Waterfall() to make these comments read/write or just read-only. Submitted: Brian Warner ( warner ) - 2006-10-09 07:29

Extra Comments :-

I have submitted a patch here: http://sourceforge.net/tracker/index.php?func=detail&aid=1575715&group_id=73177&atid=537003

Change History (5)

comment:1 Changed 10 years ago by ipv6guru

  • Type changed from defect to enhancement

Moved from sourceforge

comment:2 Changed 10 years ago by dustin

  • Description modified (diff)
  • Milestone changed from undecided to 1.0.+

This is a cool idea .. I thought there was a similar bug already, btu I can't find it.

comment:3 Changed 9 years ago by ddunbar

  • Cc daniel@… added

comment:4 Changed 9 years ago by ddunbar

Has the patch which was submitted for this been lost? I would really like to try it out.

comment:5 Changed 9 years ago by dustin

  • Keywords web added; sourceforge 1573390 removed

Eek - this runs in a direction counter to how the web status works now. I'm not sure I like that!

Note: See TracTickets for help on using tickets.