ShellCommand not working with params on Windows

[ipv6guru]

As follow up to mail thread on the dev list:  http://sourceforge.net/mailarchive/forum.php?thread_id=30770272&forum_id=32 301

ShellCommand? steps to a windows build slave don't work properly. I can identify two different problems:

• cannot pass a path with spaces in it
• cannot pass parameters to the command

Error output: '"C:Program Files (x86)Microsoft Visual Studio 8Common7IDEdevenv.exe"" /build ""Debug|Win32"' is not recognized as an internal or external command, operable program or batch file.

C:WINDOWSsystem32cmd.exe /c "C:Program Files (x86)Microsoft Visual Studio 8Common7IDEdevenv.exe" /build "Debug|Win32" /out build.log in dir d:BuildBotwin32uild (timeout 1200 secs) watching logfiles {} argv: ['C:\WINDOWS\system32\cmd.exe', '/c', '"C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE\devenv.exe"', '/build', '"Debug|Win32"', '/out', 'build.log']

The slave is an XP x64 box. Submitted: Timothee Besset ( ttimo ) - 2006-10-25 04:36

[ipv6guru]

Moved from sourceforge

[dustin]

I think that marcus has since fixed this up.

[zooko]

Since the args included a pipe char, this is probably an instance of  http://twistedmatrix.com/trac/ticket/3933 . Dustin: do you remember what marcus changed that may have fixed this?

[dustin]

sorry, no -- the windows stuff is foreign to me, and untestable by me, so I largely take it on faith.

[dabrahams]

This is definitely not fixed. At least, I still can't launch an executable with a space in its pathname. Do you not have a windows buildslave testing this? If you do have a windows buildslave, are you testing that specific case?

[dustin]

Nope, this needs a windows maintainer to take a look. I can't test if I don't know how to fix it.

[fcrestois]

look a duplicate of #377

[dustin]

Is it? This deals specifically with | in the args - or is that just a special-case of bug #377?

[dustin]

Yes, dupe #377, which is fixed.